Improved argument description for parameters originating from tuples#30084
Merged
ahejlsberg merged 3 commits intomicrosoft:masterfrom Mar 18, 2019
Merged
Improved argument description for parameters originating from tuples#30084ahejlsberg merged 3 commits intomicrosoft:masterfrom
ahejlsberg merged 3 commits intomicrosoft:masterfrom
Conversation
…that were extracted from functions. (ie mapped functions)
Contributor
Author
|
On a personal note, this issue has been bugging me since 3.0, hope it gets merged :) |
Contributor
Author
|
@RyanCavanaugh Is there anything blocking this PR and anything I can do to move it along? Or is it just a matter of time and priorities and someone will get to it when they get to it :) ? |
ahejlsberg
reviewed
Mar 10, 2019
ahejlsberg
reviewed
Mar 10, 2019
Member
|
@dragomirtitian Added a few comments in the code. If you update the PR we'll get it merged. |
added 2 commits
March 11, 2019 02:31
ahejlsberg
approved these changes
Mar 11, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Improved argument description for parameters originating from tuples that were extracted from functions. (ie mapped functions).
If the function parameters come from a tuple extracted from function parameters, then the signature help now provides the same information as the quick info. This means that if the tuple was extracted from a function we will now have the same names for the parameters as in the original function.
Ex:
Implementation notes:
I added
getExpandedParameterstoTypeCheckerbut marked it as internal so as not to impact the public API. This function might however be useful for clients of the API. Let me know if I should remove the internal.If the argument of the mapped function is a single rest parameter the name of the parameter is not preserved in the quick info. Since this fix uses the same function as quick info (
getExpandedParameters) it will suffer from the same issue.This seems to be caused by the fact that the signature parameters will just have the rest parameter (
...a: num[]) not a tuple with the rest (...a: [...number[]]).This could be the topic of a different issue.
function fnTest3(...a: [number, string]) { }) the quick info shows a signature with the tuple spread to several parameters and an index added (function fnTest3(a_0: number, a_1: string): void) this will also now be shown by the signature help as well. While this does not seem like a great improvement at least it is consistent.Fixes #26563, #28127, #29514